feat(preprod): use artifact url from response#2697
Closed
NicoHinderling wants to merge 2 commits intomasterfrom
Closed
feat(preprod): use artifact url from response#2697NicoHinderling wants to merge 2 commits intomasterfrom
NicoHinderling wants to merge 2 commits intomasterfrom
Conversation
NicoHinderling
requested review from
a team and
szokeasaurusrex
as code owners
NicoHinderling
force-pushed
the
one-more-tweak-mobile-app
branch
from
8c4cf18 to
ebd41c0
Compare
szokeasaurusrex
approved these changes
Aug 11, 2025
Member
There was a problem hiding this comment.
small nit: I would rename the PR to ref(preprod): Rename variables to indicate they store URLs.
From what I can tell, this PR is a refactor, and would not actually change any behavior. The current title makes it seem otherwise.
Edit: just realized I was wrong about this
| pub missing_chunks: Vec<Digest>, | ||
| pub detail: Option<String>, | ||
| pub artifact_id: Option<String>, | ||
| pub artifact_url: Option<String>, |
Member
There was a problem hiding this comment.
Ah wait, this produces a behavior change. We now are trying to deserialize a field named artifact_url instead of artifact_id
Member
|
CI is failing, likely because you have to update the mocks to return the |
Member
|
Closed in favor of #2698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought I pushed these changes to #2675 on sunday but I must have only committed them to my local